Skip to content

Java: use java 17 in no-wrapper tests #20194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Aug 8, 2025

Gradle 9 requires Java 17.

(cherry picked from commit 72843b5)

Gradle 9 requires Java 17.

(cherry picked from commit 72843b5)
@Copilot Copilot AI review requested due to automatic review settings August 8, 2025 15:53
@redsun82 redsun82 requested a review from a team as a code owner August 8, 2025 15:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Java integration tests to use Java 17 instead of Java 11 for Gradle 9 compatibility, as Gradle 9 requires Java 17 as the minimum runtime version.

  • Updates test function parameters from use_java_11 to use_java_17 across four Android sample test files
  • Ensures compatibility with Gradle 9's Java 17 requirement

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
java/ql/integration-tests/java/android-sample-old-style-no-wrapper/test.py Updates test function to use Java 17 instead of Java 11
java/ql/integration-tests/java/android-sample-old-style-kotlin-build-script-no-wrapper/test.py Updates test function to use Java 17 instead of Java 11
java/ql/integration-tests/java/android-sample-no-wrapper/test.py Updates test function to use Java 17 instead of Java 11
java/ql/integration-tests/java/android-sample-kotlin-build-script-no-wrapper/test.py Updates test function to use Java 17 instead of Java 11

@github-actions github-actions bot added the Java label Aug 8, 2025
@redsun82 redsun82 merged commit 56ada6b into rc/3.18 Aug 8, 2025
3 of 6 checks passed
@redsun82 redsun82 deleted the redsun82/java-fix-tests branch August 8, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant